Files
michaelschiemer/src/Framework/Http/RequestBody.php
Michael Schiemer 9b74ade5b0 feat: Fix discovery system critical issues
Resolved multiple critical discovery system issues:

## Discovery System Fixes
- Fixed console commands not being discovered on first run
- Implemented fallback discovery for empty caches
- Added context-aware caching with separate cache keys
- Fixed object serialization preventing __PHP_Incomplete_Class

## Cache System Improvements
- Smart caching that only caches meaningful results
- Separate caches for different execution contexts (console, web, test)
- Proper array serialization/deserialization for cache compatibility
- Cache hit logging for debugging and monitoring

## Object Serialization Fixes
- Fixed DiscoveredAttribute serialization with proper string conversion
- Sanitized additional data to prevent object reference issues
- Added fallback for corrupted cache entries

## Performance & Reliability
- All 69 console commands properly discovered and cached
- 534 total discovery items successfully cached and restored
- No more __PHP_Incomplete_Class cache corruption
- Improved error handling and graceful fallbacks

## Testing & Quality
- Fixed code style issues across discovery components
- Enhanced logging for better debugging capabilities
- Improved cache validation and error recovery

Ready for production deployment with stable discovery system.

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
2025-08-13 12:04:17 +02:00

130 lines
3.3 KiB
PHP

<?php
declare(strict_types=1);
namespace App\Framework\Http;
/**
* Represents the parsed body of an HTTP request
* No longer directly accesses superglobals
*/
final readonly class RequestBody
{
/** @var array<string, mixed> */
public array $data;
/**
* @param Method $method HTTP method
* @param Headers $headers Request headers
* @param string $body Raw request body
* @param array<string, mixed> $parsedData Pre-parsed data (from parser)
*/
public function __construct(
Method $method,
Headers $headers,
string $body,
/** @var array<string, mixed> $parsedData Pre-parsed data (from parser) */
array $parsedData
) {
// For GET requests, data comes from query parameters (passed as parsedData)
if ($method === Method::GET) {
$this->data = $parsedData;
return;
}
// For other methods, check if we have pre-parsed data
if (! empty($parsedData)) {
$this->data = $parsedData;
return;
}
// If no pre-parsed data, parse based on content type
$contentType = $headers->get(HeaderKey::CONTENT_TYPE);
// Normalize content type
if (is_array($contentType)) {
$contentType = $contentType[0] ?? '';
} elseif ($contentType === null) {
$contentType = '';
}
// Parse based on content type
if (str_contains($contentType, MimeType::APPLICATION_JSON->value)) {
$this->data = json_decode($body, true) ?? [];
} elseif (str_contains($contentType, MimeType::APPLICATION_FORM->value)) {
parse_str($body, $parsedBody);
$this->data = $parsedBody;
} else {
// For other content types or empty body
$this->data = [];
}
}
/**
* Get a value from the parsed body
*
* @param string $key The key to retrieve
* @param mixed $default Default value if key doesn't exist
* @return mixed The value or default
*/
public function get(string $key, mixed $default = null): mixed
{
return $this->data[$key] ?? $default;
}
/**
* Check if a key exists in the parsed body
*
* @param string $key The key to check
* @return bool
*/
public function has(string $key): bool
{
return isset($this->data[$key]);
}
/**
* Get all parsed data
*
* @return array<string, mixed>
*/
public function all(): array
{
return $this->data;
}
/**
* Get a subset of the data by keys
*
* @param array<string> $keys Keys to include
* @return array<string, mixed>
*/
public function only(array $keys): array
{
return array_intersect_key($this->data, array_flip($keys));
}
/**
* Get all data except specified keys
*
* @param array<string> $keys Keys to exclude
* @return array<string, mixed>
*/
public function except(array $keys): array
{
return array_diff_key($this->data, array_flip($keys));
}
/**
* Get all parsed data as array (alias for all() method)
*
* @return array<string, mixed>
*/
public function toArray(): array
{
return $this->data;
}
}