michael/michaelschiemer
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

feat: Fix discovery system critical issues

Browse Source 
Resolved multiple critical discovery system issues:

## Discovery System Fixes
- Fixed console commands not being discovered on first run
- Implemented fallback discovery for empty caches
- Added context-aware caching with separate cache keys
- Fixed object serialization preventing __PHP_Incomplete_Class

## Cache System Improvements
- Smart caching that only caches meaningful results
- Separate caches for different execution contexts (console, web, test)
- Proper array serialization/deserialization for cache compatibility
- Cache hit logging for debugging and monitoring

## Object Serialization Fixes
- Fixed DiscoveredAttribute serialization with proper string conversion
- Sanitized additional data to prevent object reference issues
- Added fallback for corrupted cache entries

## Performance & Reliability
- All 69 console commands properly discovered and cached
- 534 total discovery items successfully cached and restored
- No more __PHP_Incomplete_Class cache corruption
- Improved error handling and graceful fallbacks

## Testing & Quality
- Fixed code style issues across discovery components
- Enhanced logging for better debugging capabilities
- Improved cache validation and error recovery

Ready for production deployment with stable discovery system.

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
This commit is contained in:
Michael Schiemer
2025-08-13 12:04:17 +02:00
parent 66f7efdcfc
commit 9b74ade5b0
494 changed files with 764014 additions and 1127382 deletions
Download Patch File Download Diff File Expand all files Collapse all files

122
src/Framework/Mcp/Tools/FrameworkAgents.php
View File

@@ -28,15 +28,15 @@ final readonly class FrameworkAgents
'properties' => [
'task' => [
'type' => 'string',
'description' => 'The framework-specific task to analyze or implement'
'description' => 'The framework-specific task to analyze or implement',
],
'focus' => [
'type' => 'string',
'enum' => ['architecture', 'patterns', 'di', 'immutability', 'composition'],
'description' => 'Specific focus area for the framework core agent'
]
'description' => 'Specific focus area for the framework core agent',
],
],
'required' => ['task']
'required' => ['task'],
]
)]
public function frameworkCoreAgent(string $task, ?string $focus = null): array
@@ -50,10 +50,10 @@ final readonly class FrameworkAgents
// Framework health check
$healthCheck = $this->frameworkTools->frameworkHealthCheck();
// Analyze current framework structure
$modules = $this->frameworkTools->listFrameworkModules();
// Get container bindings analysis
$containerAnalysis = $this->frameworkTools->analyzeContainerBindings();
@@ -66,7 +66,7 @@ final readonly class FrameworkAgents
'No Inheritance - Composition over inheritance',
'Immutable by Design - readonly classes and properties',
'Explicit DI - No global state or service locators',
'Attribute-Driven - Convention over configuration'
'Attribute-Driven - Convention over configuration',
],
'task_analysis' => $analysis,
'framework_health' => $healthCheck,
@@ -77,8 +77,8 @@ final readonly class FrameworkAgents
'quality_standards' => [
'Framework Compliance: 100%',
'Immutability: Prefer readonly/final',
'Type Safety: Value Objects over primitives'
]
'Type Safety: Value Objects over primitives',
],
];
}
@@ -90,25 +90,25 @@ final readonly class FrameworkAgents
'properties' => [
'task' => [
'type' => 'string',
'description' => 'The MCP-specific task to analyze or implement'
'description' => 'The MCP-specific task to analyze or implement',
],
'integration_type' => [
'type' => 'string',
'enum' => ['tools', 'resources', 'analysis', 'discovery', 'health'],
'description' => 'Type of MCP integration focus'
]
'description' => 'Type of MCP integration focus',
],
],
'required' => ['task']
'required' => ['task'],
]
)]
public function mcpSpecialistAgent(string $task, ?string $integration_type = null): array
{
// Discover existing MCP tools
$mcpTools = $this->discoverMcpTools();
// Framework routes analysis for MCP integration
$routes = $this->frameworkTools->analyzeRoutes();
// Attribute discovery for MCP patterns
$mcpToolAttributes = $this->frameworkTools->discoverAttributes('App\\Framework\\Mcp\\McpTool');
@@ -119,7 +119,7 @@ final readonly class FrameworkAgents
'core_principles' => [
'Framework-Aware MCP - Use framework MCP server for internal analysis',
'Safe Sandbox Operations - Respect project-scoped file access',
'Attribute-Driven Discovery - Understand #[McpTool] and #[McpResource] patterns'
'Attribute-Driven Discovery - Understand #[McpTool] and #[McpResource] patterns',
],
'task_analysis' => [
'task' => $task,
@@ -136,8 +136,8 @@ final readonly class FrameworkAgents
'quality_standards' => [
'Framework Integration: Optimal use of framework MCP tools',
'Safety First: Respect sandbox limitations',
'Discovery Compliance: Follow framework attribute patterns'
]
'Discovery Compliance: Follow framework attribute patterns',
],
];
}
@@ -149,22 +149,22 @@ final readonly class FrameworkAgents
'properties' => [
'task' => [
'type' => 'string',
'description' => 'The value object or domain modeling task'
'description' => 'The value object or domain modeling task',
],
'domain_area' => [
'type' => 'string',
'enum' => ['core', 'http', 'security', 'performance', 'business'],
'description' => 'Domain area for value object focus'
]
'description' => 'Domain area for value object focus',
],
],
'required' => ['task']
'required' => ['task'],
]
)]
public function valueObjectAgent(string $task, ?string $domain_area = null): array
{
// Scan for existing value objects in the framework
$valueObjects = $this->scanForValueObjects();
// Analyze potential primitive obsession
$primitiveAnalysis = $this->analyzePrimitiveUsage();
@@ -175,7 +175,7 @@ final readonly class FrameworkAgents
'core_principles' => [
'No Primitive Obsession - Never primitive arrays/strings for domain concepts',
'Immutable Value Objects - All VOs readonly with transformation methods',
'Rich Domain Modeling - VOs contain domain-specific validation and logic'
'Rich Domain Modeling - VOs contain domain-specific validation and logic',
],
'task_analysis' => [
'task' => $task,
@@ -188,14 +188,14 @@ final readonly class FrameworkAgents
'Core VOs' => ['Email', 'RGBColor', 'Url', 'Hash', 'Version', 'Coordinates'],
'HTTP VOs' => ['FlashMessage', 'ValidationError', 'RouteParameters'],
'Security VOs' => ['OWASPEventIdentifier', 'MaskedEmail', 'ThreatLevel'],
'Performance VOs' => ['Measurement', 'MetricContext', 'MemorySummary']
'Performance VOs' => ['Measurement', 'MetricContext', 'MemorySummary'],
],
'vo_patterns' => $this->getValueObjectPatterns(),
'quality_standards' => [
'Type Safety: 100% - No primitives for domain concepts',
'Immutability: All VOs readonly with transformation methods',
'Domain Richness: VOs contain relevant business logic'
]
'Domain Richness: VOs contain relevant business logic',
],
];
}
@@ -207,25 +207,25 @@ final readonly class FrameworkAgents
'properties' => [
'task' => [
'type' => 'string',
'description' => 'The attribute discovery or configuration task'
'description' => 'The attribute discovery or configuration task',
],
'attribute_system' => [
'type' => 'string',
'enum' => ['routing', 'mcp', 'commands', 'events', 'middleware'],
'description' => 'Specific attribute system to focus on'
]
'description' => 'Specific attribute system to focus on',
],
],
'required' => ['task']
'required' => ['task'],
]
)]
public function discoveryExpertAgent(string $task, ?string $attribute_system = null): array
{
// Analyze current discovery system performance
$discoveryPerformance = $this->analyzeDiscoveryPerformance();
// Get all attribute-based components
$attributeComponents = $this->scanAttributeComponents();
$recommendations = $this->generateDiscoveryRecommendations($task, $attribute_system);
return [
@@ -233,7 +233,7 @@ final readonly class FrameworkAgents
'core_principles' => [
'Attribute-Driven Everything - Routes, Middleware, Commands, MCP tools via attributes',
'Convention over Configuration - Minimize manual config through discovery',
'Performance-Aware Caching - Cache discovery results for performance'
'Performance-Aware Caching - Cache discovery results for performance',
],
'task_analysis' => [
'task' => $task,
@@ -246,26 +246,26 @@ final readonly class FrameworkAgents
'Routing' => ['#[Route]', '#[Auth]', '#[MiddlewarePriority]'],
'MCP Integration' => ['#[McpTool]', '#[McpResource]'],
'Commands' => ['#[ConsoleCommand]', '#[CommandHandler]'],
'Events' => ['#[EventHandler]', '#[DomainEvent]']
'Events' => ['#[EventHandler]', '#[DomainEvent]'],
],
'quality_standards' => [
'Discovery Coverage: 100% - All components via attributes',
'Performance: Cached discovery results for production',
'Convention Compliance: Strict framework attribute patterns'
]
'Convention Compliance: Strict framework attribute patterns',
],
];
}
private function generateFrameworkRecommendations(string $task, ?string $focus): array
{
$recommendations = [];
if (str_contains(strtolower($task), 'service') || str_contains(strtolower($task), 'class')) {
$recommendations[] = 'Use final readonly class with explicit constructor DI';
$recommendations[] = 'Avoid extends - prefer composition over inheritance';
$recommendations[] = 'Use Value Objects instead of primitive parameters';
}
if (str_contains(strtolower($task), 'controller') || str_contains(strtolower($task), 'api')) {
$recommendations[] = 'Use #[Route] attributes for endpoint definition';
$recommendations[] = 'Create specific Request objects instead of array parameters';
@@ -284,7 +284,7 @@ final readonly class FrameworkAgents
private function generateMcpRecommendations(string $task, ?string $integration_type): array
{
$recommendations = [];
if (str_contains(strtolower($task), 'tool') || $integration_type === 'tools') {
$recommendations[] = 'Use #[McpTool] attribute with clear name and description';
$recommendations[] = 'Provide inputSchema for complex tool parameters';
@@ -303,7 +303,7 @@ final readonly class FrameworkAgents
private function generateValueObjectRecommendations(string $task, ?string $domain_area): array
{
$recommendations = [];
if (str_contains(strtolower($task), 'primitive') || str_contains(strtolower($task), 'array')) {
$recommendations[] = 'Replace primitive arrays with typed Value Objects';
$recommendations[] = 'Create readonly classes with validation in constructor';
@@ -322,7 +322,7 @@ final readonly class FrameworkAgents
private function generateDiscoveryRecommendations(string $task, ?string $attribute_system): array
{
$recommendations = [];
if (str_contains(strtolower($task), 'performance') || str_contains(strtolower($task), 'cache')) {
$recommendations[] = 'Use cached reflection provider for attribute scanning';
$recommendations[] = 'Implement discovery result caching for production';
@@ -343,16 +343,16 @@ final readonly class FrameworkAgents
return [
'service_pattern' => [
'description' => 'Framework-compliant service class',
'example' => 'final readonly class UserService { public function __construct(private readonly UserRepository $repo) {} }'
'example' => 'final readonly class UserService { public function __construct(private readonly UserRepository $repo) {} }',
],
'controller_pattern' => [
'description' => 'Attribute-based controller with typed responses',
'example' => '#[Route(path: \'/api/users\', method: Method::POST)] public function create(CreateUserRequest $request): JsonResult'
'example' => '#[Route(path: \'/api/users\', method: Method::POST)] public function create(CreateUserRequest $request): JsonResult',
],
'value_object_pattern' => [
'description' => 'Immutable value object with validation',
'example' => 'final readonly class Email { public function __construct(public string $value) { /* validation */ } }'
]
'example' => 'final readonly class Email { public function __construct(public string $value) { /* validation */ } }',
],
];
}
@@ -361,12 +361,12 @@ final readonly class FrameworkAgents
return [
'mcp_tool_pattern' => [
'description' => 'Framework MCP tool with proper attributes',
'example' => '#[McpTool(name: \'analyze_domain\', description: \'Analyze domain structure\')] public function analyzeDomain(): array'
'example' => '#[McpTool(name: \'analyze_domain\', description: \'Analyze domain structure\')] public function analyzeDomain(): array',
],
'mcp_resource_pattern' => [
'description' => 'Framework MCP resource with URI pattern',
'example' => '#[McpResource(uri: \'framework://config/{key}\')] public function getConfig(string $key): array'
]
'example' => '#[McpResource(uri: \'framework://config/{key}\')] public function getConfig(string $key): array',
],
];
}
@@ -375,12 +375,12 @@ final readonly class FrameworkAgents
return [
'immutable_vo' => [
'description' => 'Immutable value object with validation',
'example' => 'final readonly class Price { public function __construct(public int $cents, public Currency $currency) {} }'
'example' => 'final readonly class Price { public function __construct(public int $cents, public Currency $currency) {} }',
],
'transformation_method' => [
'description' => 'Value object transformation instead of mutation',
'example' => 'public function add(self $other): self { return new self($this->cents + $other->cents, $this->currency); }'
]
'example' => 'public function add(self $other): self { return new self($this->cents + $other->cents, $this->currency); }',
],
];
}
@@ -389,7 +389,7 @@ final readonly class FrameworkAgents
try {
$mcpToolsDir = __DIR__;
$tools = [];
foreach (glob($mcpToolsDir . '/*.php') as $file) {
$content = file_get_contents($file);
preg_match_all('/#\[McpTool\([^)]+name:\s*[\'"]([^\'"]+)[\'"]/', $content, $matches);
@@ -397,7 +397,7 @@ final readonly class FrameworkAgents
$tools[] = $toolName;
}
}
return $tools;
} catch (\Throwable) {
return ['analyze_routes', 'analyze_container_bindings', 'discover_attributes', 'framework_health_check', 'list_framework_modules'];
@@ -413,7 +413,7 @@ final readonly class FrameworkAgents
'core' => ['Email', 'Url', 'Hash', 'Version'],
'http' => ['FlashMessage', 'ValidationError', 'RouteParameters'],
'security' => ['OWASPEventIdentifier', 'MaskedEmail', 'ThreatLevel'],
'performance' => ['Measurement', 'MetricContext', 'MemorySummary']
'performance' => ['Measurement', 'MetricContext', 'MemorySummary'],
];
} catch (\Throwable) {
return [];
@@ -425,7 +425,7 @@ final readonly class FrameworkAgents
return [
'analysis' => 'Primitive obsession analysis would require code scanning',
'recommendation' => 'Implement automated scanning for array/string parameters in domain methods',
'priority_areas' => ['User management', 'Order processing', 'Payment handling']
'priority_areas' => ['User management', 'Order processing', 'Payment handling'],
];
}
@@ -436,8 +436,8 @@ final readonly class FrameworkAgents
'recommendations' => [
'Implement discovery timing metrics',
'Cache reflection results in production',
'Monitor attribute scanning performance'
]
'Monitor attribute scanning performance',
],
];
}
@@ -445,12 +445,12 @@ final readonly class FrameworkAgents
{
try {
$components = [];
// Scan for different attribute types
$attributeTypes = [
'Route' => 'App\\Framework\\Attributes\\Route',
'McpTool' => 'App\\Framework\\Mcp\\McpTool',
'ConsoleCommand' => 'App\\Framework\\Attributes\\ConsoleCommand'
'ConsoleCommand' => 'App\\Framework\\Attributes\\ConsoleCommand',
];
foreach ($attributeTypes as $name => $class) {
@@ -467,4 +467,4 @@ final readonly class FrameworkAgents
return ['error' => 'Could not scan attribute components'];
}
}
}
}